Email subject prefix

allan · March 10, 2022, 11:45am

Hi.

I see in the code there is the possibility of setting a prefix for notification subject emails.
Does this work already?
I set the env variable but cant see the prefix in notification emails.

I cant see it impremented in the code nor could I find any issues/PRs on github.
Any advice @frjo ?

thanks allan

frjo · March 10, 2022, 12:09pm

EMAIL_SUBJECT_PREFIX is a standard Django setting.

https://docs.djangoproject.com/en/4.0/ref/settings#email-subject-prefix

It is not used anywhere in Hypha. It was added early on and just stuck around.

I think we could remove it.

Instead we can add a ORG_EMAIL_SUBJECT_PREFIX that is used for all e-mails Hypha sends.

It could get inserted here:

github.com

HyphaApp/hypha/blob/6554683d5756d1932418282ea2d225aa22c9b5ce/hypha/apply/activity/tasks.py#L10-L20

      
        
            def send_mail(subject, message, from_address, recipients, logs=None):
                # Convenience method to wrap the tasks and handle the callback
                send_mail_task.apply_async(
                    kwargs={
                        'subject': subject,
                        'body': message,
                        'from_email': from_address,
                        'to': recipients,
                    },
                    link=update_message_status.s([log.pk for log in logs]),
                )

A default value of '[Hypha] ' or maybe even better f'[{settings.ORG_SHORT_NAME}] '.

allan · March 10, 2022, 1:09pm

brilliant! thanks very much @frjo

frjo · March 11, 2022, 7:07am

github.com/HyphaApp/hypha

Implement a ORG_EMAIL_SUBJECT_PREFIX setting

opened 07:07AM - 11 Mar 22 UTC

frjo

Type: Enhancement

The existing setting `EMAIL_SUBJECT_PREFIX` is a standard Django setting. htt…ps://docs.djangoproject.com/en/4.0/ref/settings#email-subject-prefix It is not used anywhere in Hypha. It was added early on and just stuck around. I think we could remove it since Hypha do not send out any mails that use it. Please confirm that first. Instead we can add a `ORG_EMAIL_SUBJECT_PREFIX` that is used for all e-mails Hypha sends. It could get inserted here: https://github.com/HyphaApp/hypha/blob/6554683d5756d1932418282ea2d225aa22c9b5ce/hypha/apply/activity/tasks.py#L10-L20 A default value of `'[Hypha] '` or maybe even better `f'[{settings.ORG_SHORT_NAME}] '`. Setting it as empty string should mimic how it works today, no prefix at all.

Topic		Replies	Views
Hypha 3.3.0 released Dev Releases	0	254	October 26, 2022
Maintainer's Call 17 August 2021 Maintainers	0	333	August 15, 2021
Hypha Meeting: 2022 August 2nd Maintainers	2	255	August 1, 2022
Maintainer’s Call 19th October 2021 Maintainers	0	355	October 19, 2021
Revising automated email notifications notifications	0	259	February 8, 2022

Email subject prefix

Related topics